Skip to content

ctl: fix https client panic (#8239)#8247

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-8239-to-release-8.1
Jul 29, 2024
Merged

ctl: fix https client panic (#8239)#8247
ti-chi-bot[bot] merged 4 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-8239-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Jun 4, 2024

This is an automated cherry-pick of #8239

What problem does this PR solve?

Issue Number: Close #8237, Ref #7300

What is changed and how does it work?

fix panic when call pd-ctl cluster with tls

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@okJiang @ti-chi-bot
This is an automated cherry-pick of tikv#8239
934a859 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: no Indicates the PR's author has not signed dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2024
Merged
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Jun 4, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot Bot requested review from HuSharp and rleungx June 4, 2024 13:21
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 4, 2024
okJiang added 2 commits July 29, 2024 17:24
@okJiang
Merge branch 'release-8.1' of github.com:tikv/pd into cherry-pick-823…
876cbac 
…9-to-release-8.1
@okJiang
fix conflict
a16831e 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Copy Markdown
Member

okJiang commented Jul 29, 2024

/cherry-pick-invite

@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Jul 29, 2024

@okJiang Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/pd/invitations

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 29, 2024
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 09:31:55.562319655 +0000 UTC m=+175431.842367724: ☑️ agreed by HuSharp.
  • 2024-07-29 09:33:05.436109811 +0000 UTC m=+175501.716157880: ☑️ agreed by rleungx.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Jul 29, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot Bot merged commit 632ee6e into tikv:release-8.1 Jul 29, 2024
@HuSharp HuSharp deleted the cherry-pick-8239-to-release-8.1 branch July 29, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

@HuSharp HuSharp HuSharp approved these changes

Assignees

@JmPotato JmPotato

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @okJiang @rleungx @HuSharp @JmPotato